Solving for faster SHA-1 collision detection

This seems extremely cool, but man does it also sound complicated. The write up was thorough but the algorithm seems so complicated that the author can't even write good tests for it is concerning. I would be very concerned their algorithm might accidentally skip something important accidentally given they are dealing with dynamically combining large binary expressions. You can make it fast, but if you can't prove it and it's security related that probably needs to be proved out more, even if SHA1 is already compromised.

• bawolff · 2 hours ago

  Why do you conclude the author cannot write good tests for it?

• ted_dunning · 42 minutes ago

  Fuzz tests with tailored random distributions and good logical property tests are excellent tests. What would you do better? Also, the author didn't say that there were no other tests. They just said that they use fuzz + property tests a fair bit.

This writing almost feels AI, but it's not AI. Why is that?

• bawolff · 2 hours ago

  This reads like a totally normal article to me. At some point these AI accusations feel like a witch hunt.

Does git proper already accepts rust? 2x faster pack checks would be worthwhile, as it affects everybody. I heard since 2.55 they already do

• masklinn · 1 hour ago

  Git proper has had rust code in it since 2.52, as an opt-in optional. 2.55 makes it opt out. 3.0 might make it required.